Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlDatabasePermission: Added localization #1341

Merged
merged 1 commit into from
Apr 27, 2019
Merged

SqlDatabasePermission: Added localization #1341

merged 1 commit into from
Apr 27, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Apr 26, 2019 •
edited by joeyaiello
Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju changed the title Changes to SqlDatabasePermission SqlDatabasePermission: Add localization Apr 26, 2019
@johlju johlju changed the title SqlDatabasePermission: Add localization SqlDatabasePermission: Added localization Apr 26, 2019
@johlju johlju added the needs review The pull request needs a code review. label Apr 26, 2019
@codecov-io
Copy link

codecov-io commented Apr 26, 2019 •
edited
Loading

Codecov Report

Merging #1341 into dev will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##            dev   #1341    +/-   ##
=====================================
+ Coverage    98%     98%   +<1%     
=====================================
  Files        36      36            
  Lines      5089    5094     +5     
=====================================
+ Hits       5020    5025     +5     
  Misses       69      69

@johlju
Changes to SqlDatabasePermission
b8a22ae 
- Added en-US localization (issue dsccommunity#608).
johlju
johlju commented Apr 27, 2019
View reviewed changes
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit faa809f into dsccommunity:dev Apr 27, 2019
@kwirkykat kwirkykat removed the needs review The pull request needs a code review. label Apr 27, 2019
@johlju johlju deleted the fix-issue-608 branch April 27, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SqlDatabasePermission: Localization should change to align with HQRM modules
3 participants
@johlju @codecov-io @kwirkykat